many changes to add typing in place of 'any's etc

1 files changed, 18 insertions, 15 deletions

diff --git a/src/client/documents/Documents.ts b/src/client/documents/Documents.ts
index b96fdb4bd..d7fdf016c 100644
--- a/src/client/documents/Documents.ts
+++ b/src/client/documents/Documents.ts
@@ -141,12 +141,12 @@ class RtfInfo extends FInfo {
 }
 class ListInfo extends FInfo {
     fieldType? = FInfoFieldType.list;
-    values?: List<any>[] = [];
+    values?: List<FieldType>[] = [];
 }
 type BOOLt = BoolInfo | boolean;
 type NUMt = NumInfo | number;
 type STRt = StrInfo | string;
-type LISTt = ListInfo | List<any>;
+type LISTt = ListInfo | List<FieldType>;
 type DOCt = DocInfo | Doc;
 type RTFt = RtfInfo | RichTextField;
 type DIMt = DimInfo; // | typeof DimUnit.Pixel | typeof DimUnit.Ratio;
@@ -358,7 +358,7 @@ export class DocumentOptions {
     presentation_duration?: NUMt = new NumInfo('the duration of the slide in presentation view', false);
     presentation_zoomText?: BOOLt = new BoolInfo('whether text anchors should shown in a larger box when following links to make them stand out', false);
 
-    data?: any;
+    data?: FieldType;
     data_useCors?: BOOLt = new BoolInfo('whether CORS protocol should be used for web page');
     columnHeaders?: List<SchemaHeaderField>; // headers for stacking views
     schemaHeaders?: List<SchemaHeaderField>; // headers for schema view
@@ -464,13 +464,14 @@ export class DocumentOptions {
     sidebar_color?: string; // background color of text sidebar
     sidebar_type_collection?: string; // collection type of text sidebar
 
-    data_dashboards?: List<any>; // list of dashboards used in shareddocs;
+    data_dashboards?: List<FieldType>; // list of dashboards used in shareddocs;
     textTransform?: string;
     letterSpacing?: string;
     iconTemplate?: string; // name of icon template style
+    icon_fieldKey?: string; // specifies the icon template to use (e.g., icon_fieldKey='george', then the icon template's name is icon_george; otherwise, the template's name would be icon_<type> where type is the Doc's type(pdf,rich text, etc))
     selectedIndex?: NUMt = new NumInfo("which item in a linear view has been selected using the 'thumb doc' ui");
 
-    fieldValues?: List<any>; // possible values a field can have (used by FieldInfo's only)
+    fieldValues?: List<FieldType>; // possible values a field can have (used by FieldInfo's only)
     fieldType?: string; // display type of a field, e.g. string, number, enumeration (used by FieldInfo's only)
 
     clipboard?: Doc;
@@ -484,7 +485,10 @@ export class DocumentOptions {
 }
 
 export const DocOptions = new DocumentOptions();
+
+// eslint-disable-next-line @typescript-eslint/no-namespace
 export namespace Docs {
+    // eslint-disable-next-line @typescript-eslint/no-namespace
     export namespace Prototypes {
         type LayoutSource = { LayoutString: (key: string) => string };
         type PrototypeTemplate = {
@@ -492,7 +496,6 @@ export namespace Docs {
                 view: LayoutSource;
                 dataField: string;
             };
-            data?: any;
             options?: Partial<DocumentOptions>;
         };
         type TemplateMap = Map<DocumentType, PrototypeTemplate>;
@@ -554,7 +557,7 @@ export namespace Docs {
             const actualProtos = await DocServer.GetRefFields(prototypeIds);
             // update this object to include any default values: DocumentOptions for all prototypes
             prototypeIds.forEach(id => {
-                const existing = actualProtos[id] as Doc;
+                const existing = actualProtos.get(id);
                 const type = id.replace(suffix, '') as DocumentType;
                 // get or create prototype of the specified type...
                 const target = buildPrototype(type, id, existing);
@@ -627,16 +630,15 @@ export namespace Docs {
                 acl_Guest: SharingPermissions.View,
                 ...(template.options || {}),
                 layout: layout.view?.LayoutString(layout.dataField),
-                data: template.data,
             };
             Object.entries(options)
                 .filter(pair => typeof pair[1] === 'string' && pair[1].startsWith('@'))
                 .forEach(pair => {
                     if (!existing || ScriptCast(existing[pair[0]])?.script.originalScript !== pair[1].substring(1)) {
-                        (options as any)[pair[0]] = ComputedField.MakeFunction(pair[1].substring(1));
+                        (options as { [key: string]: unknown })[pair[0]] = ComputedField.MakeFunction(pair[1].substring(1));
                     }
                 });
-            return Doc.assign(existing ?? new Doc(prototypeId, true), OmitKeys(options, Object.keys(existing ?? {})).omit, undefined, true);
+            return Doc.assign(existing ?? new Doc(prototypeId, true), OmitKeys(options, Object.keys(existing ?? {})).omit as { [key: string]: FieldType }, undefined, true);
         }
     }
 
@@ -644,6 +646,7 @@ export namespace Docs {
      * Encapsulates the factory used to create new document instances
      * delegated from top-level prototypes
      */
+    // eslint-disable-next-line @typescript-eslint/no-namespace
     export namespace Create {
         /**
          * This function receives the relevant document prototype and uses
@@ -667,10 +670,10 @@ export namespace Docs {
         function InstanceFromProto(proto: Doc, data: FieldType | undefined, options: DocumentOptions, delegId?: string, fieldKey: string = 'data', protoId?: string, placeholderDocIn?: Doc, noView?: boolean) {
             const placeholderDoc = placeholderDocIn;
             const viewKeys = ['x', 'y', 'isSystem']; // keys that should be addded to the view document even though they don't begin with an "_"
-            const { omit: dataProps, extract: viewProps } = OmitKeys(options, viewKeys, '^_');
+            const { omit: dataProps, extract: viewProps } = OmitKeys(options, viewKeys, '^_') as { omit: { [key: string]: FieldType | undefined }; extract: { [key: string]: FieldType | undefined } };
 
             // dataProps.acl_Override = SharingPermissions.Unset;
-            dataProps.acl_Guest = options.acl_Guest ?? (Doc.defaultAclPrivate ? SharingPermissions.None : SharingPermissions.View);
+            dataProps.acl_Guest = options.acl_Guest?.toString() ?? (Doc.defaultAclPrivate ? SharingPermissions.None : SharingPermissions.View);
             dataProps.isSystem = viewProps.isSystem;
             dataProps.isDataDoc = true;
             dataProps.author = ClientUtils.CurrentUserEmail();
@@ -693,7 +696,7 @@ export namespace Docs {
             }
 
             if (!noView) {
-                const viewFirstProps: { [id: string]: any } = { author: ClientUtils.CurrentUserEmail() };
+                const viewFirstProps: { [id: string]: FieldType } = { author: ClientUtils.CurrentUserEmail() };
                 viewFirstProps.acl_Guest = options._acl_Guest ?? (Doc.defaultAclPrivate ? SharingPermissions.None : SharingPermissions.View);
                 let viewDoc: Doc;
                 // determines whether viewDoc should be created using placeholder Doc or default
@@ -710,7 +713,7 @@ export namespace Docs {
                     viewDoc = Doc.assign(Doc.MakeDelegate(dataDoc, delegId), viewFirstProps, true, true);
                 }
                 Doc.assign(viewDoc, viewProps, true, true);
-                if (![DocumentType.LINK, DocumentType.CONFIG, DocumentType.LABEL].includes(viewDoc.type as any)) {
+                if (![DocumentType.LINK, DocumentType.CONFIG, DocumentType.LABEL].includes(viewDoc.type as DocumentType)) {
                     CreateLinkToActiveAudio(() => viewDoc);
                 }
                 updateCachedAcls(dataDoc);
@@ -909,7 +912,7 @@ export namespace Docs {
         }
 
         export function ConfigDocument(options: DocumentOptions, id?: string) {
-            return InstanceFromProto(Prototypes.get(DocumentType.CONFIG), options?.data, options, id, '', undefined, undefined, true);
+            return InstanceFromProto(Prototypes.get(DocumentType.CONFIG), undefined, options, id, '', undefined, undefined, true);
         }
 
         export function PileDocument(documents: Array<Doc>, options: DocumentOptions, id?: string) {