trying to improve how data / layout / root and templtae docs are accessed.

2 files changed, 20 insertions, 4 deletions

diff --git a/src/fields/Doc.ts b/src/fields/Doc.ts
index fc89dcbe7..f5bd4f44c 100644
--- a/src/fields/Doc.ts
+++ b/src/fields/Doc.ts
@@ -320,10 +320,11 @@ export class Doc extends RefField {
                     UpdatingFromServer,
                     Width,
                     '__LAYOUT__',
+                    '__DATA__',
                 ];
             },
             getOwnPropertyDescriptor: (target, prop) => {
-                if (prop.toString() === '__LAYOUT__' || !(prop in target[FieldKeys])) {
+                if (prop.toString() === '__DATA__' || prop.toString() === '__LAYOUT__' || !(prop in target[FieldKeys])) {
                     return Reflect.getOwnPropertyDescriptor(target, prop);
                 }
                 return {
@@ -400,6 +401,9 @@ export class Doc extends RefField {
     public [ToString] = () => `Doc(${GetEffectiveAcl(this[SelfProxy]) === AclPrivate ? '-inaccessible-' : this[SelfProxy].title})`;
     public get [DocLayout]() { return this[SelfProxy].__LAYOUT__; } // prettier-ignore
     public get [DocData](): Doc {
+        return this[SelfProxy].__DATA__;
+    }
+    @computed get __DATA__(): Doc {
         const self = this[SelfProxy];
         return self.resolvedDataDoc && !self.isTemplateForField ? self : Doc.GetProto(Cast(Doc.Layout(self).resolvedDataDoc, Doc, null) || self);
     }
@@ -414,7 +418,7 @@ export class Doc extends RefField {
             } else {
                 return Cast(layoutField, Doc, null);
             }
-            return Cast(self[renderFieldKey + '_layout[' + templateLayoutDoc[Id] + ']'], Doc, null) || templateLayoutDoc;
+            return Cast(self['layout_' + templateLayoutDoc.title + '(' + renderFieldKey + ')'], Doc, null) || templateLayoutDoc;
         }
         return undefined;
     }
@@ -865,7 +869,7 @@ export namespace Doc {
         // If it doesn't find the expanded layout, then it makes a delegate of the template layout and
         // saves it on the data doc indexed by the template layout's id.
         //
-        const expandedLayoutFieldKey = templateField + '_layout[' + templateLayoutDoc[Id] + ']';
+        const expandedLayoutFieldKey = 'layout_' + templateLayoutDoc.title + '(' + templateField + ')';
         let expandedTemplateLayout = targetDoc?.[expandedLayoutFieldKey];
 
         if (templateLayoutDoc.resolvedDataDoc instanceof Promise) {
@@ -1152,7 +1156,9 @@ export namespace Doc {
     // the document containing the view layout information - will be the Document itself unless the Document has
     // a layout field or 'layout' is given.
     export function Layout(doc: Doc, layout?: Doc): Doc {
-        const overrideLayout = layout && Cast(doc[`${StrCast(layout.isTemplateForField, 'data')}_layout[` + layout[Id] + ']'], Doc, null);
+        const templateField = layout && StrCast(layout.isTemplateForField, Doc.LayoutFieldKey(layout)); // the field that the template renders
+        const overrideLayout = layout && Cast(doc[layout.title + '(' + templateField + ')'], Doc, null);
+        //  [`${StrCast(layout.isTemplateForField, 'data')}_layout[` + layout[Id] + ']'], Doc, null);
         return overrideLayout || doc[DocLayout] || doc;
     }
     export function SetLayout(doc: Doc, layout: Doc | string) {
diff --git a/src/fields/util.ts b/src/fields/util.ts
index 33764aca5..abbe543e8 100644
--- a/src/fields/util.ts
+++ b/src/fields/util.ts
@@ -314,6 +314,13 @@ export function setter(target: ListImpl<FieldType> | Doc, inProp: string | symbo
     // if you're trying to change an acl but don't have Admin access / you're trying to change it to something that isn't an acceptable acl, you can't
     if (typeof prop === 'string' && prop.startsWith('acl_') && (effectiveAcl !== AclAdmin || ![...Object.values(SharingPermissions), undefined].includes(value as SharingPermissions))) return true;
 
+    if (typeof prop === 'string' && prop !== '__id' && prop !== '__fieldTuples' && prop.startsWith('$')) {
+        prop = prop.substring(1);
+        if (target.__DATA__ instanceof Doc) {
+            target.__DATA__[prop] = value as FieldResult;
+            return true;
+        }
+    }
     if (typeof prop === 'string' && prop !== '__id' && prop !== '__fieldTuples' && prop.startsWith('_')) {
         if (!prop.startsWith('__')) prop = prop.substring(1);
         if (target.__LAYOUT__ instanceof Doc) {
@@ -351,6 +358,7 @@ export function getter(target: Doc | ListImpl<FieldType>, prop: string | symbol,
         case DocAcl :   return target[DocAcl];
         case $mobx:     return target.__fieldTuples[prop];
         case DocLayout: return target.__LAYOUT__;
+        case DocData:   return target.__DATA__;
         case Height: case Width: if (GetEffectiveAcl(target) === AclPrivate) return returnZero;
         // eslint-disable-next-line no-fallthrough
         default :
@@ -362,6 +370,8 @@ export function getter(target: Doc | ListImpl<FieldType>, prop: string | symbol,
 
     const layoutProp = prop.startsWith('_') ? prop.substring(1) : undefined;
     if (layoutProp && target.__LAYOUT__) return (target.__LAYOUT__ as Doc)[layoutProp];
+    const dataProp = prop.startsWith('$') ? prop.substring(1) : undefined;
+    if (dataProp && target.__DATA__) return (target.__DATA__ as Doc)[dataProp];
     return getFieldImpl(target, layoutProp ?? prop, proxy);
 }