1 files changed, 29 insertions, 26 deletions
diff --git a/src/client/views/ScriptBox.tsx b/src/client/views/ScriptBox.tsx
index d24256886..153b81876 100644
--- a/src/client/views/ScriptBox.tsx
+++ b/src/client/views/ScriptBox.tsx
@@ -12,6 +12,7 @@ import { CompileScript } from "../util/Scripting";
 import { ScriptField } from "../../new_fields/ScriptField";
 import { DragManager } from "../util/DragManager";
 import { EditableView } from "./EditableView";
+import { getEffectiveTypeRoots } from "typescript";
 
 export interface ScriptBoxProps {
     onSave: (text: string, onError: (error: string) => void) => void;
@@ -43,14 +44,12 @@ export class ScriptBox extends React.Component<ScriptBoxProps> {
 
     overlayDisposer?: () => void;
     onFocus = () => {
-        if (this.overlayDisposer) {
-            this.overlayDisposer();
-        }
+        this.overlayDisposer?.();
         this.overlayDisposer = OverlayView.Instance.addElement(<DocumentIconContainer />, { x: 0, y: 0 });
     }
 
     onBlur = () => {
-        this.overlayDisposer && this.overlayDisposer();
+        this.overlayDisposer?.();
     }
 
     render() {
@@ -93,30 +92,34 @@ export class ScriptBox extends React.Component<ScriptBoxProps> {
         const params: string[] = [];
         const setParams = (p: string[]) => params.splice(0, params.length, ...p);
         const scriptingBox = <ScriptBox initialText={originalText} setParams={setParams} onCancel={overlayDisposer} onSave={(text, onError) => {
-            const script = CompileScript(text, {
-                params: { this: Doc.name, ...contextParams },
-                typecheck: false,
-                editable: true,
-                transformer: DocumentIconContainer.getTransformer()
-            });
-            if (!script.compiled) {
-                onError(script.errors.map(error => error.messageText).join("\n"));
-                return;
-            }
+            if (!text) {
+                Doc.GetProto(doc)[fieldKey] = undefined;
+            } else {
+                const script = CompileScript(text, {
+                    params: { this: Doc.name, ...contextParams },
+                    typecheck: false,
+                    editable: true,
+                    transformer: DocumentIconContainer.getTransformer()
+                });
+                if (!script.compiled) {
+                    onError(script.errors.map(error => error.messageText).join("\n"));
+                    return;
+                }
 
-            const div = document.createElement("div");
-            div.style.width = "90";
-            div.style.height = "20";
-            div.style.background = "gray";
-            div.style.position = "absolute";
-            div.style.display = "inline-block";
-            div.style.transform = `translate(${clientX}px, ${clientY}px)`;
-            div.innerHTML = "button";
-            params.length && DragManager.StartButtonDrag([div], text, doc.title + "-instance", {}, params, (button: Doc) => { }, clientX, clientY);
+                const div = document.createElement("div");
+                div.style.width = "90";
+                div.style.height = "20";
+                div.style.background = "gray";
+                div.style.position = "absolute";
+                div.style.display = "inline-block";
+                div.style.transform = `translate(${clientX}px, ${clientY}px)`;
+                div.innerHTML = "button";
+                params.length && DragManager.StartButtonDrag([div], text, doc.title + "-instance", {}, params, (button: Doc) => { }, clientX, clientY);
 
-            doc[fieldKey] = new ScriptField(script);
-            overlayDisposer();
+                Doc.GetProto(doc)[fieldKey] = new ScriptField(script);
+                overlayDisposer();
+            }
         }} showDocumentIcons />;
-        overlayDisposer = OverlayView.Instance.addWindow(scriptingBox, { x: 400, y: 200, width: 500, height: 400, title: title });
+        overlayDisposer = OverlayView.Instance.addWindow(scriptingBox, { x: 400, y: 200, width: 500, height: 400, title });
     }
 }